Config parsing rough initial idea #1
Conversation
|
Small refactor of the auth logic, happy to discuss tomorrow |
| @@ -1,3 +1,2 @@ | |||
| CONFIG_FILE_NAME = ".env.qnx" | |||
| ACCESS_TOKEN_FILE_PATH = ".qnx/auth/access_token" | |||
| REFRESH_TOKEN_FILE_PATH = ".qnx/auth/refresh_token" | |||
| TOKEN_FILE_PATH = ".qnx/auth" | |||
There was a problem hiding this comment.
I've kept these separate so that we can point to the jupyter hub refresh token in the pod separately from the access token.
There was a problem hiding this comment.
We can discuss later today and refactor back by all means - have you thought at all about how we could supportXDG_CONFIG_HOME as a valid config dir? Plenty of linux users like using this but not sure how well it would gel
There was a problem hiding this comment.
👍 . Nope, I wasn't aware of this as an option. I've just defaulted to the home directory.
There was a problem hiding this comment.
We could check if it is set and use it instead of the home directory.
There was a problem hiding this comment.
https://github.com/CQCL/tket/blob/fc43ebf3adf0f7cb96a214d051034eb95822377a/pytket/pytket/config/pytket_config.py#L23 I wrote some code for pytket a while back that does this if it's of use.
There was a problem hiding this comment.
Have made an issue for it: #2
Possibly don't need to address it in this PR
There was a problem hiding this comment.
Nice, looks like we could directly copy and paste that 😛
No description provided.